Skip to content

Fix error message in headless request.go #5768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2024
Merged

Fix error message in headless request.go #5768

merged 1 commit into from
Oct 25, 2024

Conversation

@dmaciejak
Copy link
Contributor

@dmaciejak dmaciejak commented Oct 24, 2024 •
edited by dogancanbakir
Loading

I have that error displayed which sounds grammatically wrong:

Could not execute request for http://x.x.x.x/: could get html element: error occurred executing action: [:RUNTIME] could not navigate to url http://x.x.x.x/login <- navigation failed: net::ERR_ADDRESS_UNREACHABLE

closes #5770

Proposed changes

Fixing the message

Checklist

  • Pull request is created against the dev branch
  • All checks passed (lint, unit/integration/regression tests etc.) with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@dmaciejak
Fix error message in request.go
b07cf2c 
I have that error displayed which sounds grammatically wrong:

Could not execute request for http://x.x.x.x/: could get html element: error occurred executing action: [:RUNTIME] could not navigate to url http://x.x.x.x/login <- navigation failed: net::ERR_ADDRESS_UNREACHABLE
@auto-assign auto-assign bot requested a review from dogancanbakir October 24, 2024 17:11
@GeorginaReeder
Copy link

GeorginaReeder commented Oct 25, 2024

Thanks so much for your contribution @dmaciejak ! :)

@ehsandeep ehsandeep merged commit 2039b5c into projectdiscovery:dev Oct 25, 2024
11 of 12 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Nov 21, 2024
Merged
@blsaccess blsaccess mentioned this pull request Nov 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ehsandeep ehsandeep ehsandeep approved these changes

@dogancanbakir dogancanbakir dogancanbakir approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix error message in headless request.go

4 participants

@dmaciejak @GeorginaReeder @ehsandeep @dogancanbakir